Helm/loki-stack: add template for the service name to connect to loki #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
should we bump the chart loki-stack version too ? |
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
|
@cyriltovena Thx for helping, I forgot to bump the chart ver. |
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
* Spread the sync load over time Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com> * Move seed to main Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
mraboosk
pushed a commit
to mraboosk/loki
that referenced
this pull request
Oct 7, 2024
…grafana#1587) * add helper for the service name to connect to loki * Bump loki-chart version. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com> Co-authored-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds the template for the service name to connect to loki.
Helm chart for loki-stack requires template "loki.serviceName", but it doesn't exist.
Which issue(s) this PR fixes:
Fixes #1566
Special notes for your reviewer:
Checklist