Clarify regex escaping rules #1601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YAML treats backslashes in double-quoted strings differently than backslashes in non-double-quoted strings. This commit clarifies the behavior for the regex stage. Closes grafana#1597
rfratto
force-pushed
the
fix-regex-pipeline-examples
branch
from
7273d6e to
88b04cc
Compare
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
In DynamoDB metrics autoscaling, ignore throttling below some level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
YAML treats backslashes in double-quoted strings differently than backslashes in non-double-quoted strings. This PR clarifies the behavior for the regex stage.
I've tested all the various cases and verified that escaping backslashes are only required when using double quotes.
Closes #1597.