Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes frontend args in libsonnet. #1739

Merged
merged 1 commit into from
Feb 25, 2020

Conversation

cyriltovena
Copy link
Contributor

I forgot to update it to use common args.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

Mistakes were made.

I forgot to update it to use common args.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #1739 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1739      +/-   ##
==========================================
+ Coverage   64.17%   64.22%   +0.05%     
==========================================
  Files         121      121              
  Lines        9083     9083              
==========================================
+ Hits         5829     5834       +5     
+ Misses       2849     2846       -3     
+ Partials      405      403       -2
Impacted Files Coverage Δ
pkg/ingester/transfer.go 65% <0%> (-1.43%) ⬇️
pkg/logql/evaluator.go 91.81% <0%> (+0.58%) ⬆️
pkg/promtail/targets/filetarget.go 70.55% <0%> (+1.84%) ⬆️
pkg/promtail/targets/tailer.go 75.86% <0%> (+2.29%) ⬆️

@cyriltovena cyriltovena merged commit 0ffa65a into grafana:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants