Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo: Not a binary operator: = #1776

Merged
merged 1 commit into from
Mar 5, 2020
Merged

fix typo: Not a binary operator: = #1776

merged 1 commit into from
Mar 5, 2020

Conversation

eraac
Copy link
Contributor

@eraac eraac commented Mar 5, 2020

What this PR does / why we need it: Fix a typo in common.libsonnet

Special notes for your reviewer:

$ tk show environments/loki
evaluating jsonnet: RUNTIME ERROR: [...]/loki/vendor/loki/common.libsonnet:10:66-67 Not a binary operator: =
	[...]/loki/vendor/loki/loki.libsonnet:4:2-27	$
	main.jsonnet:2:14-42	thunk <loki> from <$>
	main.jsonnet:4:1-5	$
	During evaluation

Copy link
Member

@sh0rez sh0rez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, that shouldn't have been merged in the first place.

LGTM for me 🚀

/cc @slim-bean @rfratto

Copy link
Member

@rfratto rfratto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as well, thanks for fixing this!

@sh0rez sh0rez merged commit a9f25a3 into grafana:master Mar 5, 2020
@codecov-io
Copy link

Codecov Report

Merging #1776 into master will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1776      +/-   ##
==========================================
+ Coverage   64.34%   64.38%   +0.04%     
==========================================
  Files         121      121              
  Lines        9086     9086              
==========================================
+ Hits         5846     5850       +4     
+ Misses       2836     2834       -2     
+ Partials      404      402       -2
Impacted Files Coverage Δ
pkg/ingester/transfer.go 66.42% <0%> (+1.42%) ⬆️
pkg/promtail/targets/tailer.go 78.4% <0%> (+2.27%) ⬆️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants