Support configurable maximum of the limits parameter #1798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyriltovena
reviewed
Mar 13, 2020
cyriltovena
reviewed
Mar 13, 2020
cyriltovena
reviewed
Mar 13, 2020
cyriltovena
reviewed
Mar 13, 2020
adityacs
force-pushed
the
1795_Configurable_maximum_limits_parameter
branch
6 times, most recently
from
52ac0ca
to
0f666de
Compare
cyriltovena
reviewed
Mar 16, 2020
cyriltovena
reviewed
Mar 16, 2020
adityacs
force-pushed
the
1795_Configurable_maximum_limits_parameter
branch
2 times, most recently
from
812c003
to
b0731c2
Compare
cyriltovena
reviewed
Mar 19, 2020
cyriltovena
reviewed
Mar 19, 2020
cyriltovena
reviewed
Mar 19, 2020
cyriltovena
reviewed
Mar 19, 2020
|
This looks ready except for the zero case which I think you can quickly solve. Checking why the CI fails. EDIT: you have a test failing ! |
adityacs
force-pushed
the
1795_Configurable_maximum_limits_parameter
branch
3 times, most recently
from
cda504c
to
f5d2508
Compare
|
@cyriltovena Have made all the changes. I see that currently we don't have complete testing for the |
Codecov Report
@@ Coverage Diff @@
## master #1798 +/- ##
==========================================
- Coverage 64.86% 64.69% -0.17%
==========================================
Files 122 122
Lines 9239 9271 +32
==========================================
+ Hits 5993 5998 +5
- Misses 2833 2856 +23
- Partials 413 417 +4
|
cyriltovena
reviewed
Mar 23, 2020
| @@ -326,3 +337,17 @@ func writeError(err error, w http.ResponseWriter) { | |||
| http.Error(w, err.Error(), http.StatusInternalServerError) | |||
| } | |||
| } | |||
|
|
|||
| func (q *Querier) validateEntriesLimits(ctx context.Context, limit uint32) error { | |||
There was a problem hiding this comment.
You need to validate this also for LogQueryHandler but only once we have verified it's a log request.
So after those lines:
// short circuit metric queries
if _, ok := expr.(logql.SampleExpr); ok {
writeError(httpgrpc.Errorf(http.StatusBadRequest, "legacy endpoints only support %s result type", logql.ValueTypeStreams), w)
return
}
f5d2508
to
5635f66
Compare
adityacs
force-pushed
the
1795_Configurable_maximum_limits_parameter
branch
from
1274006
to
68c0218
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1798 +/- ##
==========================================
- Coverage 64.86% 64.69% -0.17%
==========================================
Files 122 122
Lines 9239 9271 +32
==========================================
+ Hits 5993 5998 +5
- Misses 2833 2856 +23
- Partials 413 417 +4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Support configurable maximum of the limits parameter
Which issue(s) this PR fixes:
Fixes #1795
Checklist