Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky promtail test #1865

Merged
merged 1 commit into from
Apr 3, 2020
Merged

Fix flaky promtail test #1865

merged 1 commit into from
Apr 3, 2020

Conversation

adityacs
Copy link
Contributor

What this PR does / why we need it:
Fix flaky promtail test which was causing few test failures.

Which issue(s) this PR fixes:
Fixes #1520

@cyriltovena
Copy link
Contributor

Thanks ! Could you give some details on what was the problem ? I'll take a look tmw.

@adityacs
Copy link
Contributor Author

@cyriltovena I am still digging at it. I am not able to reproduce the error.
As you suggested earlier, I was checking for the race, there is a race when running this test but I couldn't make anything useful from the result

@cyriltovena
Copy link
Contributor

Does that change fixes the race ? I think it should.

@adityacs
Copy link
Contributor Author

It will not fix the race exactly. I am using map. So, it won't verify the order. It will just check if the entry is present in map.

@cyriltovena
Copy link
Contributor

Would be nice if you could also fix the race in that PR.

@adityacs
Copy link
Contributor Author

Sure. I have pinged this issue in loki-dev channel. I need some help figuring this out.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit e713a8d into grafana:master Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky promtail test
2 participants