-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #2014
Spelling #2014
Changes from all commits
84f15ec
214c3b3
f099107
ccc8876
d15ebdb
8005d54
6df63d1
a0a1f15
a673b9e
5b148f1
3f67e6a
d4f8a7e
8b368bf
cc7002a
d84a3b9
73cd4c5
300e6df
9bf6ecc
5b56233
ca61112
5068378
3110635
a549eaa
61e9d61
3fe5243
580a030
7d7af0c
00e357a
7613e7a
06f77d9
6fb843d
804fe51
57cdb10
9b54cb1
c22612b
d1fc7dd
96840cf
37181f9
e592f4e
873f1fd
9bae037
598cd81
ebbafe5
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -24,7 +24,7 @@ The current team members are: | |
- David Kaltschmidt [davkal](https://github.com/davkal) | ||
- Edward Welch [slim-bean](https://github.com/slim-bean) | ||
- Goutham Veeramachaneni [gouthamve](https://github.com/gouthamve) | ||
- Joe Elliott [joe-elliot](https://github.com/joe-elliot) | ||
- Joe Elliott [joe-elliott](https://github.com/joe-elliott) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry @joe-elliott I did this. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. thanks for the fix :) |
||
- Owen Diehl [owen-d](https://github.com/owen-d) | ||
- Robert Fratto [rfratto](https://github.com/rfratto) | ||
- Sandeep Sukhani [sandeepsukhani](https://github.com/sandeepsukhani) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -240,7 +240,7 @@ The `grpc_client_config` block configures a client connection to a gRPC service. | |
# Enable backoff and retry when a rate limit is hit. | ||
[backoff_on_ratelimits: <bool> | default = false] | ||
|
||
# Configures backoff when enbaled. | ||
# Configures backoff when enabled. | ||
backoff_config: | ||
# Minimum delay when backing off. | ||
[min_period: <duration> | default = 100ms] | ||
|
@@ -282,7 +282,7 @@ The `ingester_config` block configures Ingesters. | |
# How long chunks should sit in-memory with no updates before | ||
# being flushed if they don't hit the max block size. This means | ||
# that half-empty chunks will still be flushed after a certain | ||
# period as long as they receieve no further activity. | ||
# period as long as they receive no further activity. | ||
[chunk_idle_period: <duration> | default = 30m] | ||
|
||
# The targeted _uncompressed_ size in bytes of a chunk block | ||
|
@@ -388,7 +388,7 @@ kvstore: | |
- <string> | ||
|
||
# The Dial timeout for the ETCD connection. | ||
[dial_tmeout: <duration> | default = 10s] | ||
[dial_timeout: <duration> | default = 10s] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. are we 100% sure this is a typo in the docs and not a config actually spelled wrong? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Afaict, the only instances of that are the document itself: |
||
|
||
# The maximum number of retries to do for failed ops to ETCD. | ||
[max_retries: <int> | default = 10] | ||
|
@@ -433,7 +433,7 @@ aws: | |
# DynamoDB rate cap to back off when throttled. | ||
[throttle_limit: <float> | default = 10.0] | ||
|
||
# Metics-based autoscaling configuration. | ||
# Metrics-based autoscaling configuration. | ||
metrics: | ||
# Use metrics-based autoscaling via this Prometheus query URL. | ||
[url: <string>] | ||
|
@@ -453,7 +453,7 @@ aws: | |
# Query to fetch throttle rates per table | ||
[write_throttle_query: <string> | default = "sum(rate(cortex_dynamo_throttled_total{operation="DynamoDB.BatchWriteItem"}[1m])) by (table) > 0"] | ||
|
||
# Quer to fetch write capacity usage per table | ||
# Query to fetch write capacity usage per table | ||
[write_usage_query: <string> | default = "sum(rate(cortex_dynamo_consumed_capacity_total{operation="DynamoDB.BatchWriteItem"}[15m])) by (table) > 0"] | ||
|
||
# Query to fetch read capacity usage per table | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol this misspelling was intentional FWIW 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure I looked at the PR and decided it didn't need to be misspelled.
If something is very clearly intentionally misspelled and doesn't make sense otherwise, I do leave it alone, e.g. a changelog entry of
spelling: cirlce -> circle
.My personal preference is to not include misspellings in changelogs, unless it's announcing an API change.