Lambda-Promtail #2282
Merged
Lambda-Promtail #2282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2282 +/- ##
=======================================
Coverage 62.79% 62.79%
=======================================
Files 162 162
Lines 13952 13952
=======================================
Hits 8761 8761
- Misses 4508 4509 +1
+ Partials 683 682 -1
|
cyriltovena
reviewed
Jul 28, 2020
.gitignore
Outdated
| @@ -23,3 +23,4 @@ dlv | |||
| rootfs/ | |||
| dist | |||
| coverage.txt | |||
| .aws-sam | |||
cyriltovena
reviewed
Jul 28, 2020
docs/README.md
Outdated
| @@ -39,8 +39,9 @@ simplifies the operation and significantly lowers the cost of Loki. | |||
| 5. [Troubleshooting](clients/promtail/troubleshooting.md) | |||
| 2. [Docker Driver](clients/docker-driver/README.md) | |||
| 1. [Configuration](clients/docker-driver/configuration.md) | |||
| 4. [Fluent Bit](../cmd/fluent-bit/README.md) | |||
| 3. [Fluentd](clients/fluentd/README.md) | |||
| 3. [Fluent Bit](../cmd/fluent-bit/README.md) | |||
There was a problem hiding this comment.
I think you need to merge master back in. some of those has changed.
cyriltovena
approved these changes
Jul 28, 2020
cyriltovena
pushed a commit
to cyriltovena/loki
that referenced
this pull request
Jun 11, 2021
Signed-off-by: Bryan Boreham <bryan@weave.works>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR specs out
lambda-promtail, an AWS lambda adapter for pushing logs to loki via an intermediary set of promtails.Why
We've had many requests for a workflow that supports ephemeral jobs like those of AWS Lambda.
Balancing Labels & Ordering
Generally the problem here is reduced to cardinality problems vs ordering in distributed systems. Basically, how do we group logs from the same "job" but different invocations in the same log stream? This depends on an as-of-yet unimplemented addition to promtail which would expose the Push API but defer timestamping of logs to the promtail level rather than at the client (whatever is pushing to promtail). This would allow us to put a bank of promtails in front for scalability/HA reasons, each applying timestamps as they receive logs via the Push API. To avoid out-of-order issues, each promtail will still need to add their own differentiating label value to incoming streams, making the worst-case scenario multiply the stream count by the number of promtails. However, this is still controllable and a significant improvement over creating a stream at the invocation level (essentially labeling by uuid).
/cc @slim-bean