-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Canary tweaks #2350
Canary tweaks #2350
Conversation
…gging, improve the mutex locking a bit, add a read timeout on the websocket, add a lastmessage time checker to restart websocket
change metric count reporting to two separate metrics, expected vs actual
Codecov Report
@@ Coverage Diff @@
## master #2350 +/- ##
==========================================
+ Coverage 61.50% 61.52% +0.02%
==========================================
Files 160 160
Lines 13536 13534 -2
==========================================
+ Hits 8325 8327 +2
+ Misses 4587 4583 -4
Partials 624 624
|
//If this entry equals or exceeds the spot check interval from the last entry in the spot check array, add it. | ||
c.spotEntMtx.Lock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very confused on the double lock/unlock instead of the single lock for this function, but I don't see it being a problem either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
# Conflicts: # docs/operations/upgrade.md
Co-authored-by: Owen Diehl <ow.diehl@gmail.com>
A few follow up fixes after the PR yesterday mainly: