Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promtail: Bug: loki push api, clone labels before handling #2464

Merged
merged 1 commit into from
Aug 4, 2020
Merged

Promtail: Bug: loki push api, clone labels before handling #2464

merged 1 commit into from
Aug 4, 2020

Commits on Aug 4, 2020

  1. Make a clone of the LabelSet before handling, the handler contains a … 

    …full pipeline and can modify the labels uniquely per each line which will lead to some concurrent map access panics if you don't pass a copy of the labels to each Handle invocation.
    @slim-bean
    slim-bean committed Aug 4, 2020
    Configuration menu
    Copy the full SHA
    542906b View commit details
    Browse the repository at this point in the history