compactor for compacting boltdb files uploaded by shipper #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owen-d
approved these changes
Aug 20, 2020
| // send all files to readObjectChan | ||
| go func() { | ||
| for _, object := range objects { | ||
| if tm == nil { |
There was a problem hiding this comment.
tm doesn't appear used at all beyond this.
Thanks for the review Owen! I have taken care of the changes and also removed the code which causes go mod to change. |
Codecov Report
@@ Coverage Diff @@
## master #2526 +/- ##
==========================================
- Coverage 63.56% 63.43% -0.13%
==========================================
Files 163 166 +3
Lines 14305 14543 +238
==========================================
+ Hits 9093 9226 +133
- Misses 4499 4578 +79
- Partials 713 739 +26
|
sandeepsukhani
force-pushed
the
boltdb-shipper-compactor
branch
from
a6509d2
to
026cd41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds compactor service for compacting boltdb files uploaded by shipper.
It would run every 4 hours and requires at least 4 files in a table to compact it since it is not a lot of overhead to query just 2 or 3 files.
I am processing multiple files concurrently and have used batch writes for boltdb which allows concurrent writes without which it was taking a lot of time to compact the files. Without concurrency and batch writes for 3 GB of data it was taking more than an hour and with the improvements, it takes close to 7 minutes on my machine.
Checklist