Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a counter for empty syslog messages #2565

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

carlpett
Copy link
Contributor

What this PR does / why we need it:
This PR adds a counter for empty syslog messages.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@codecov-commenter
Copy link

Codecov Report

Merging #2565 into master will increase coverage by 0.06%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2565      +/-   ##
==========================================
+ Coverage   62.89%   62.96%   +0.06%     
==========================================
  Files         169      169              
  Lines       14911    14912       +1     
==========================================
+ Hits         9378     9389      +11     
+ Misses       4788     4774      -14     
- Partials      745      749       +4     
Impacted Files Coverage Δ
pkg/promtail/targets/syslog/syslogtarget.go 74.34% <0.00%> (-0.50%) ⬇️
pkg/promtail/targets/file/tailer.go 70.83% <0.00%> (-4.17%) ⬇️
pkg/promtail/positions/positions.go 59.64% <0.00%> (+13.15%) ⬆️

Copy link

@patriklindstrom patriklindstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any test that can cover this new code? Otherwise I think this i great. Would help us.

@slim-bean
Copy link
Collaborator

Thanks @carlpett! It's a bit tricky to write tests around metrics like this and the code looks good to me!

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slim-bean slim-bean merged commit 82a8cf4 into grafana:master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants