Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fluent-bit plugin support TLS #2568

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

zjj2wry
Copy link
Contributor

@zjj2wry zjj2wry commented Aug 28, 2020

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

@CLAassistant
Copy link

CLAassistant commented Aug 28, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

Codecov Report

Merging #2568 into master will increase coverage by 0.07%.
The diff coverage is 46.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2568      +/-   ##
==========================================
+ Coverage   62.98%   63.05%   +0.07%     
==========================================
  Files         168      168              
  Lines       14879    14894      +15     
==========================================
+ Hits         9371     9391      +20     
+ Misses       4762     4755       -7     
- Partials      746      748       +2     
Impacted Files Coverage Δ
cmd/fluent-bit/out_loki.go 4.87% <0.00%> (-0.26%) ⬇️
cmd/fluent-bit/config.go 81.57% <63.63%> (-1.40%) ⬇️
pkg/querier/queryrange/downstreamer.go 95.87% <0.00%> (-2.07%) ⬇️
pkg/promtail/positions/positions.go 59.64% <0.00%> (+13.15%) ⬆️

@zjj2wry
Copy link
Contributor Author

zjj2wry commented Sep 25, 2020

fixes #2672

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena
Copy link
Contributor

LGTM

waiting for the CI

@cyriltovena cyriltovena merged commit 1b2bae4 into grafana:master Sep 29, 2020
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Oct 21, 2020
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants