Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix an issue with building loki #2642

Merged
merged 1 commit into from
Sep 18, 2020

Conversation

sandeepsukhani
Copy link
Contributor

What this PR does / why we need it:
I just merged 2 PRs where the first one changes a signature of a function which the second one was using.
I forgot about that change in signature causing the build to break.
This PR fixes the issue.

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #2642 into master will decrease coverage by 1.66%.
The diff coverage is 54.12%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2642      +/-   ##
==========================================
- Coverage   62.87%   61.21%   -1.67%     
==========================================
  Files         170      172       +2     
  Lines       15051    13327    -1724     
==========================================
- Hits         9464     8158    -1306     
+ Misses       4827     4424     -403     
+ Partials      760      745      -15     
Impacted Files Coverage Δ
pkg/logcli/query/query.go 35.59% <0.00%> (-3.07%) ⬇️
pkg/loki/loki.go 0.00% <0.00%> (ø)
pkg/loki/modules.go 3.80% <0.00%> (-0.35%) ⬇️
pkg/storage/stores/shipper/compactor/compactor.go 0.00% <0.00%> (ø)
pkg/ingester/ingester.go 46.27% <45.45%> (-4.93%) ⬇️
pkg/querier/ingester_querier.go 64.75% <64.75%> (ø)
pkg/querier/querier.go 59.36% <86.66%> (-3.36%) ⬇️
pkg/storage/async_store.go 88.00% <88.00%> (ø)
pkg/storage/store.go 64.81% <88.88%> (-2.93%) ⬇️
pkg/logql/vector.go 59.09% <0.00%> (-28.41%) ⬇️
... and 171 more

@sandeepsukhani sandeepsukhani merged commit 29790ea into grafana:master Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants