Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker plugin documentation update #2689

Merged
merged 3 commits into from
Sep 29, 2020
Merged

docker plugin documentation update #2689

merged 3 commits into from
Sep 29, 2020

Conversation

pgassmann
Copy link
Contributor

@pgassmann pgassmann commented Sep 28, 2020

add --force to plugin disable
add --grant-all-permissions to upgrade command
link installation and configuration of the plugin

What this PR does / why we need it:

Plugin update with active containers.

Which issue(s) this PR fixes:
Related to: moby/moby#41246

Special notes for your reviewer:
cc @cyriltovena

Checklist

  • Documentation added
    - [ ] Tests updated

add --force to plugin disable
link installation and configuration of the plugin
@CLAassistant
Copy link

CLAassistant commented Sep 28, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2020

Codecov Report

Merging #2689 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2689      +/-   ##
==========================================
- Coverage   61.48%   61.40%   -0.09%     
==========================================
  Files         173      173              
  Lines       13412    13412              
==========================================
- Hits         8246     8235      -11     
- Misses       4411     4424      +13     
+ Partials      755      753       -2     
Impacted Files Coverage Δ
pkg/promtail/positions/positions.go 46.80% <0.00%> (-11.71%) ⬇️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cyriltovena cyriltovena merged commit 5cb3266 into grafana:master Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants