Docs: Corrected incorrect instances of (setup|set up) #2692
Conversation
philnichol
requested review from
achatterjee-grafana and
oddlittlebird
as code owners
|
|
docs/sources/architecture/_index.md
Outdated
| @@ -88,7 +88,7 @@ value is larger than the hash of the stream. When the replication factor is | |||
| larger than 1, the next subsequent tokens (clockwise in the ring) that belong to | |||
| different ingesters will also be included in the result. | |||
|
|
|||
| The effect of this hash set up is that each token that an ingester owns is | |||
| The effect of this hash setup is that each token that an ingester owns is | |||
There was a problem hiding this comment.
This version of "setup" is a noun. Please revert this change.
There was a problem hiding this comment.
Obviously happy to revert this, but shouldn't it be a noun?
Or should it be "The effect of this hash being set up is that..."?
There was a problem hiding this comment.
"Setup" is the noun version of the word. If you revert it and change nothing else, then it is correct.
Your version is also correct, but would require more words. I suggest going with the reversion.
There was a problem hiding this comment.
gotcha, apologies! Cheers for the feedback, I've reverted that change
There was a problem hiding this comment.
If you are ready for another review, I suggest clicking "Re-request review." People don't always notice comments, but the request for review sends a separate (and more visible) notification.
There was a problem hiding this comment.
Thanks, didn't know that!
Co-authored-by: Diana Payton <52059945+oddlittlebird@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #2692 +/- ##
==========================================
+ Coverage 61.48% 61.51% +0.02%
==========================================
Files 173 173
Lines 13412 13412
==========================================
+ Hits 8246 8250 +4
+ Misses 4411 4408 -3
+ Partials 755 754 -1
|
|
Thanks! |
What this PR does / why we need it:
Corrects incorrect usage of (setup|set up) in the docs
Which issue(s) this PR fixes:
No linked issue
Special notes for your reviewer:
I ran this in Grafana and they suggested I do it here too.
Checklist