Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shows cortextool lint command for loki in alerting docs #2705

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Sep 30, 2020

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #2705 into master will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2705      +/-   ##
==========================================
- Coverage   61.41%   61.35%   -0.07%     
==========================================
  Files         173      173              
  Lines       13444    13444              
==========================================
- Hits         8257     8248       -9     
- Misses       4430     4441      +11     
+ Partials      757      755       -2     
Impacted Files Coverage Δ
pkg/promtail/positions/positions.go 46.80% <0.00%> (-11.71%) ⬇️
pkg/querier/queryrange/downstreamer.go 97.64% <0.00%> (+2.35%) ⬆️

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@owen-d owen-d merged commit 499e4ef into grafana:master Sep 30, 2020
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Oct 21, 2020
Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants