Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes the frontend logs to include org_id. #2735

Merged
merged 1 commit into from
Oct 7, 2020

Conversation

cyriltovena
Copy link
Contributor

The auth middleware was happening after the stats one and so org_id was not set 🤦.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

The auth middleware was happening after the stats one and so org_id was not set 🤦.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@76e73d7). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2735   +/-   ##
=========================================
  Coverage          ?   61.44%           
=========================================
  Files             ?      173           
  Lines             ?    13465           
  Branches          ?        0           
=========================================
  Hits              ?     8274           
  Misses            ?     4434           
  Partials          ?      757           
Impacted Files Coverage Δ
pkg/loki/modules.go 3.70% <0.00%> (ø)

Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

@cyriltovena cyriltovena merged commit 81a697c into grafana:master Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants