Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Add S3 IAM policy to be able to run Compactor #2817

Merged
merged 1 commit into from
Oct 27, 2020

Conversation

scoof
Copy link
Contributor

@scoof scoof commented Oct 27, 2020

What this PR does / why we need it: Updates docs to be able to run compactor on S3 storage

@CLAassistant
Copy link

CLAassistant commented Oct 27, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

Codecov Report

Merging #2817 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2817   +/-   ##
=======================================
  Coverage   61.30%   61.30%           
=======================================
  Files         179      179           
  Lines       14438    14438           
=======================================
  Hits         8851     8851           
- Misses       4775     4779    +4     
+ Partials      812      808    -4     
Impacted Files Coverage Δ
pkg/promtail/targets/file/filetarget.go 63.38% <0.00%> (-2.82%) ⬇️
pkg/querier/queryrange/downstreamer.go 95.29% <0.00%> (-2.36%) ⬇️
...kg/storage/stores/shipper/uploads/table_manager.go 67.54% <0.00%> (+1.75%) ⬆️
pkg/storage/stores/shipper/uploads/table.go 70.50% <0.00%> (+1.84%) ⬆️

@@ -51,6 +51,7 @@ When using S3 as object storage, the following permissions are needed:
- `s3:ListBucket`
- `s3:PutObject`
- `s3:GetObject`
- `s3:DeleteObject` (if running the compactor)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- `s3:DeleteObject` (if running the compactor)
- `s3:DeleteObject` (if running the Single Store (boltdb-shipper) compactor)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ha @owen-d was quick on the trigger. Thanks for this it looks good!

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@owen-d owen-d merged commit 3b9222b into grafana:master Oct 27, 2020
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
* fix a race in purger managing in process delete requests

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* update changelog

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* fix a problem in taking address of delete requests in loops

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* minor nit

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* nit suggested in PR review

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

Co-authored-by: Marco Pracucci <marco@pracucci.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants