Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky load tables test for boltdb-shipper uploads table-manager #2891

Conversation

sandeepsukhani
Copy link
Contributor

What this PR does / why we need it:
Possible fix for flaky TestLoadTables test.
https://drone.grafana.net/grafana/loki/1162/1/2

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandeepsukhani sandeepsukhani merged commit fd451d9 into grafana:master Nov 6, 2020
cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
* stuff

Signed-off-by: Joe Elliott <number101010@gmail.com>

* Added Middleware test

Signed-off-by: Joe Elliott <number101010@gmail.com>

* Better naming.  Split New methods to not break existing calls

Signed-off-by: Joe Elliott <number101010@gmail.com>

* Added top level rule storage module

Signed-off-by: Joe Elliott <number101010@gmail.com>

* Fixed test

Signed-off-by: Joe Elliott <number101010@gmail.com>

* Don't start ruler or rulerstorage if not configured

Signed-off-by: Joe Elliott <number101010@gmail.com>

* Made injectRequestMiddleware a configuration option

Signed-off-by: Joe Elliott <number101010@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants