Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(docker-driver): Propagate promtail's client.Stop properly #2898

Merged
merged 5 commits into from
Dec 1, 2020
Merged

fix(docker-driver): Propagate promtail's client.Stop properly #2898

merged 5 commits into from
Dec 1, 2020

Commits on Nov 23, 2020

  1. impr(Makefile): add support to take docker-driver image via ENV

    @kavirajk
    kavirajk committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    e30a37f View commit details
    Browse the repository at this point in the history

  2. impr(promtail/client): Add cancelling mechanism for batchSend 

    stores `context` and its `cancel` in client and uses it to
make upstream calls that need `ctx`.

Also properly cancel's all the upstream calls that using `ctx` when
client's Stop is called.
    @kavirajk
    kavirajk committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    129ca28 View commit details
    Browse the repository at this point in the history

  3. Add StopNow() method to stop the client without retries. 

    Use `StopNow()` from the docker-driver
    @kavirajk
    kavirajk committed Nov 23, 2020
    Configuration menu
    Copy the full SHA
    820ec24 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2020

  1. Add test for StopNow

    @kavirajk
    kavirajk committed Nov 24, 2020
    Configuration menu
    Copy the full SHA
    689db80 View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2020

  1. reverting back the client.Timeout

    @kavirajk
    kavirajk committed Nov 27, 2020
    Configuration menu
    Copy the full SHA
    9355fa1 View commit details
    Browse the repository at this point in the history