Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix table deletion in table client for boltdb-shipper #2960

Merged
merged 1 commit into from
Nov 26, 2020
Merged

fix table deletion in table client for boltdb-shipper #2960

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkg/storage/stores/shipper/table_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ func (b *boltDBShipperTableClient) Stop() {
}

func (b *boltDBShipperTableClient) DeleteTable(ctx context.Context, name string) error {
objects, dirs, err := b.objectClient.List(ctx, name, delimiter)
objects, dirs, err := b.objectClient.List(ctx, name+delimiter, delimiter)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add a test for this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A test is there but it uses filesystem object client which works with or without a delimiter, we don't have an easy way to test this with hosted object stores without mocking the client.

if err != nil {
return err
}
Expand Down