Improve promtail alerts to retain the namespace label #2976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `PromtailFileMissing` should actually work in this simplified form. Please let me know if I'm missing something.
|
@pstibrany this is the reason why today's pager storm went to infra and not to you. (o: |
Codecov Report
@@ Coverage Diff @@
## master #2976 +/- ##
==========================================
- Coverage 61.86% 61.74% -0.13%
==========================================
Files 182 182
Lines 14870 14870
==========================================
- Hits 9200 9182 -18
- Misses 4822 4840 +18
Partials 848 848
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
It retains the namespace labels on alerts, which is generally useful, but concretely used for alert routing at Grafana Labs production.
Which issue(s) this PR fixes:
Misdirected pages at Grafana Labs.
Special notes for your reviewer:
The
PromtailFileMissingshould actually work in this simplifiedform. Please let me know if I'm missing something.