Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes promtail mixin dashboard. #3010

Merged
merged 1 commit into from
Dec 1, 2020

Conversation

cyriltovena
Copy link
Contributor

e14463b removed a metric that was used previously in a dashboard could not find a better way yet to use the new metric so instead I added back the recording rules.

Also fixes a missing template expansion from 899e8cc.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

 e14463b  removed a metric that was used previously in a dashboard could not find a better way yet to use the new metric so instead I added back the recording rules.

Also fixes a missing template expansion from 899e8cc.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #3010 (3afecb0) into master (410b9d9) will increase coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3010      +/-   ##
==========================================
+ Coverage   62.37%   62.43%   +0.06%     
==========================================
  Files         185      185              
  Lines       15624    15624              
==========================================
+ Hits         9745     9755      +10     
+ Misses       4953     4943      -10     
  Partials      926      926              
Impacted Files Coverage Δ
pkg/querier/queryrange/downstreamer.go 97.64% <0.00%> (+2.35%) ⬆️
pkg/querier/queryrange/limits.go 95.83% <0.00%> (+4.16%) ⬆️
pkg/promtail/targets/file/filetarget.go 66.19% <0.00%> (+4.22%) ⬆️

@owen-d owen-d merged commit 18cf9d2 into grafana:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants