Gcplog targetmanager #3083
Merged
Gcplog targetmanager #3083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for too many file changes, its the result of |
cyriltovena
reviewed
Jan 5, 2021
cyriltovena
reviewed
Jan 5, 2021
cyriltovena
reviewed
Jan 5, 2021
cyriltovena
reviewed
Jan 5, 2021
cyriltovena
reviewed
Jan 5, 2021
cyriltovena
reviewed
Jan 5, 2021
cyriltovena
reviewed
Jan 5, 2021
cyriltovena
reviewed
Jan 5, 2021
owen-d
reviewed
Jan 8, 2021
cyriltovena
reviewed
Jan 13, 2021
cyriltovena
reviewed
Jan 13, 2021
cyriltovena
reviewed
Jan 13, 2021
cyriltovena
reviewed
Jan 13, 2021
cyriltovena
reviewed
Jan 13, 2021
cyriltovena
reviewed
Jan 13, 2021
cyriltovena
reviewed
Jan 13, 2021
cyriltovena
reviewed
Jan 13, 2021
cyriltovena
reviewed
Jan 18, 2021
Lets you to scrape log entries from pubsub topic and send it to lok - Basic `Target` and `TargetManager` - Minimum config to make it work
- Create uniq label to create stream without out-of-order timestamp - extract instance id and timestamp from log entry
- Config changes on pubsub manager for testing
- Rewrite timestamp to avoid out-of-order errors on loki - Minor config changes to Pubsub Target manager
- Rename Pubsub* entities to Gcplog* - Rename pubsub package into gcplog - Add flag `KeepIncomingTimestamp` to toggle between either keeping incoming timestamps or rewriting with current timestamp - Tests for gcplog target - Docs and basic metrics to gcplog target
Codecov Report
@@ Coverage Diff @@
## master #3083 +/- ##
==========================================
- Coverage 63.33% 63.30% -0.03%
==========================================
Files 191 194 +3
Lines 16455 16535 +80
==========================================
+ Hits 10421 10467 +46
- Misses 5089 5119 +30
- Partials 945 949 +4
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3083 +/- ##
==========================================
- Coverage 63.33% 63.30% -0.03%
==========================================
Files 191 194 +3
Lines 16455 16535 +80
==========================================
+ Hits 10421 10467 +46
- Misses 5089 5119 +30
- Partials 945 949 +4
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Add new target manager to promtail that adds support for pulling logs out of pubsub topic.
Special notes for your reviewer:
Still In-progress
Checklist
Support for exclusion filter(Not applicable here. will be part of terraform script on the cloud config script.)Support for reading messages by ordering key(tried adding ordering key, but didn't work as expected)