Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes some 500 returned by querier when storage cancellation happens. #3344

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

cyriltovena
Copy link
Contributor

For unknown reasons, Cortex is transforming all errors to promql.ErrStorage
on the storage layer.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

For unknown reasons,  Cortex is transforming all errors to promql.ErrStorage
on the storage layer.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #3344 (34f8252) into master (6eb5cbb) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3344      +/-   ##
==========================================
+ Coverage   62.88%   62.95%   +0.06%     
==========================================
  Files         205      205              
  Lines       17423    17426       +3     
==========================================
+ Hits        10956    10970      +14     
+ Misses       5484     5475       -9     
+ Partials      983      981       -2     
Impacted Files Coverage Δ
pkg/util/server/error.go 100.00% <100.00%> (ø)
pkg/ingester/checkpoint.go 72.83% <0.00%> (-1.14%) ⬇️
pkg/querier/queryrange/downstreamer.go 97.64% <0.00%> (+2.35%) ⬆️
pkg/promtail/targets/file/tailer.go 78.57% <0.00%> (+5.35%) ⬆️
pkg/querier/queryrange/limits.go 87.87% <0.00%> (+6.06%) ⬆️

@slim-bean slim-bean merged commit afb539f into grafana:master Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants