Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fluentd plugin when kubernetes labels were missing #3358

Merged
merged 1 commit into from
Mar 3, 2021

Conversation

fpob
Copy link
Contributor

@fpob fpob commented Feb 18, 2021

When kubernetes labels were missing in the received data, plugin failed
with error "undefined method `each_key' for nil:NilClass".

When kubernetes labels were missing in the received data, plugin failed
with error "undefined method `each_key' for nil:NilClass".
@CLAassistant
Copy link

CLAassistant commented Feb 18, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 8c98ee2 into grafana:master Mar 3, 2021
@jcmuller
Copy link

jcmuller commented Apr 2, 2021

When can we expect a new release in rubygems including this patch?

Cheers

cyriltovena pushed a commit to cyriltovena/loki that referenced this pull request Jun 11, 2021
* fix common prefixes returned by List method of s3

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* update changelog

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>

* changes suggested from PR review

Signed-off-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
@trutty
Copy link

trutty commented Dec 9, 2021

Hi, a new version is not yet present in rubygems.org. The last uploaded version is from 2020-10-27.
Can we expect a new upload soon that includes the latest fixes? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants