Remove default docker pipeline stage #3404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ected behaviour Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
dannykopping
pushed a commit
to dannykopping/loki
that referenced
this pull request
Mar 2, 2021
Signed-off-by: Danny Kopping <danny.kopping@grafana.com>
2 tasks
cyriltovena
pushed a commit
that referenced
this pull request
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR resolves a bug whereby an omitted
pipeline_stageskey in ascrape_configsentry would result in adockerpipeline being created by default; this is unexpected and undocumented behaviour. This change was introduced when we deprecated theentry_parserconfiguration.Which issue(s) this PR fixes:
Fixes #3403
Special notes for your reviewer:
We will probably need to communicate this change clearly when it is released; this may lead to unexpected breakages of
promtailconfigurations that rely on this bug.Checklist