Improve the parser hint tests. #3429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was able to find out where was the issue with that test yesterday. Now I realized that we can mutate (re-slice) the given log line, and so other test would fail. This also make the parallel back. Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #3429 +/- ##
==========================================
- Coverage 63.36% 63.29% -0.08%
==========================================
Files 205 205
Lines 17539 17539
==========================================
- Hits 11114 11101 -13
- Misses 5429 5447 +18
+ Partials 996 991 -5
|
owen-d
approved these changes
Mar 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was able to find out where was the issue with that test yesterday.
Now I realized that we can mutate (re-slice) the given log line, and so other test would fail.
This also make the parallel back.
Signed-off-by: Cyril Tovena cyril.tovena@gmail.com