Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loki: change ReadStringAsSlice to ReadString so it doesn't parse quotes inside the packed _entry #3432

Merged
merged 1 commit into from
Mar 4, 2021
Merged

Loki: change ReadStringAsSlice to ReadString so it doesn't parse quotes inside the packed _entry #3432

merged 1 commit into from
Mar 4, 2021

Conversation

slim-bean
Copy link
Collaborator

No description provided.

kavirajk
kavirajk approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cyriltovena
cyriltovena approved these changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm we will improve perf later

@slim-bean slim-bean merged commit 6d48fb6 into master Mar 4, 2021
@slim-bean slim-bean deleted the unpack-non-json branch March 4, 2021 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

@kavirajk kavirajk kavirajk approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slim-bean @cyriltovena @kavirajk