Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce allocs in delete requests manager by reusing slice for tracing non-deleted intervals for chunks #3769

Conversation

sandeepsukhani
Copy link
Contributor

What this PR does / why we need it:
Reuse slice for tracking non-deleted intervals of chunks in delete requests manager. The change is safe since we anyways check one chunk at a time and future changes for concurrent checks are protected by a sync.Mutex.

Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sandeepsukhani sandeepsukhani merged commit 966bed7 into grafana:main May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants