-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unordered chunks #4001
Merged
Merged
Unordered chunks #4001
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
e15f53f
merge feature/unordered-replay
owen-d 1147aa3
interoperable head chunks
owen-d e2cc745
Merge remote-tracking branch 'upstream/main' into headblock-interop
owen-d e92b4da
memchunk block interop
owen-d ad4acae
retain ordered memchunk optimizations when possible
owen-d 5efceb3
tests+bench for unordered chunk reads
owen-d e3be2c4
reorder on chunk close
owen-d 35ba4fa
[wip] ingester stream unorderd
owen-d 500631c
unordered writes default in testware config, fixes OOO bug & removes …
owen-d 96661ac
validity window is 1/2 of max age & fixes old transfer test
owen-d fea3831
more consistent headblock checking/creation
owen-d 9a5e43c
more cohesive encoding tests
owen-d b9d9718
unordered stream test with validity bounds
owen-d d2c8a02
Merge remote-tracking branch 'upstream/main' into feature-unordered-i…
owen-d 3e8b165
compat - unordered
owen-d 9ba70c8
reinstates memchunk defaults when rebounding & updates storage test c…
owen-d e4b77a3
lint
owen-d 4e89368
Merge remote-tracking branch 'upstream/main' into feature-unordered-i…
owen-d a1e82f9
reorder across blocks doesnt overflow
owen-d 14b495e
respect chunk configs during rebounding when possible
owen-d 10a2008
only sync checks on ordered writes
owen-d 038cce6
Merge remote-tracking branch 'upstream/main' into feature-unordered-i…
owen-d File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might need variant of HeapIterator that just reorder samples/logs depending on how that affects performance.
I'm guessing this only happening for chunk in memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the unordered version only happens on the ingesters. Since we reorder chunks before flushing to storage (if needed), the unoptimized heapIter versions are only run on the ingesters themselves and only if the ingester is receiving out of order data.
edit: I should look at refactoring the order detection into a helper fn. These methods are way too complex for my tastes :(