Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restore /config endpoint and correct handlerFunc for buildinfo #4027

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

jdbaldry
Copy link
Member

@jdbaldry jdbaldry commented Jul 22, 2021

What this PR does / why we need it:

As far as I can tell from reading the "next" documentation, the
/loki/api/v1/status/buildinfo endpoint should return the build
information. The /version endpoint is also listed further down in the
documentation but from the code prior to this change, it looks like it
should perform the same function as buildinfo endpoint so I have
removed it.

I've updated the documentation to reflect my changes.

Special notes for your reviewer:

I'm just pulling the documentation image in order to check that the changed heading works as expected. LGTM

Checklist

  • Documentation added

As far as I can tell from reading the "next" documentation, the
/loki/api/v1/status/buildinfo endpoint should return the build
information. The /version endpoint is also listed further down in the
documentation but from the code prior to this change, it looks like it
should perform the same function as buildinfo endpoint so I have
removed it.

I've updated the documentation to reflect my changes.

Signed-off-by: Jack Baldry <jack.baldry@grafana.com>
@jdbaldry jdbaldry requested review from KMiller-Grafana and a team as code owners July 22, 2021 08:36
@CLAassistant
Copy link

CLAassistant commented Jul 22, 2021

CLA assistant check
All committers have signed the CLA.

@jdbaldry jdbaldry requested a review from jeschkies July 22, 2021 09:24
@jdbaldry
Copy link
Member Author

@jeschkies Adding you on this PR to get your insight for the previous change.

Copy link
Contributor

@jeschkies jeschkies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this! It was an error on my side. @owen-d, could you confirm?

Copy link
Member

@owen-d owen-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, nice catch.

@owen-d owen-d merged commit e22e666 into main Jul 22, 2021
@owen-d owen-d deleted the jdb/restore-config-endpoint branch July 22, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants