Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates scheduler libsonnet #4154

Merged
merged 2 commits into from
Aug 12, 2021
Merged

updates scheduler libsonnet #4154

merged 2 commits into from
Aug 12, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Aug 12, 2021 •
edited
Loading

This PR:

  1. Uses a headless svc config with PublishNotReadyAddresses for the scheduler to bootstrap scheduler<>worker connections.
  2. Improves some configuration handling, notably component addresses & tenant queues between configurations with/without the scheduler enabled.
  3. use frontend_worker.match_max_concurrent rather than calculate the worker parallelism in jsonnet.

@owen-d owen-d requested a review from a team as a code owner August 12, 2021 17:51
slim-bean
slim-bean approved these changes Aug 12, 2021
View reviewed changes
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owen-d owen-d merged commit 1ec0a31 into grafana:main Aug 12, 2021
@JoaoBraveCoding JoaoBraveCoding mentioned this pull request Mar 21, 2023
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean slim-bean approved these changes

Assignees
No one assigned
Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owen-d @slim-bean