-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clients/promtail: Add ndjson and plaintext formats to loki_push #4336
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make these small grammatical changes, and then I'll approve the documentation part of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking Great !
I have a suggestion let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The documentation portion of this PR looks good to me. Thanks for the changes, @ldb.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What this PR does / why we need it:
This change adds a generic way to send logs to Loki via HTTP. To do that it introduces a
format
option to theloki_push_api
scrape target, which can be used to describe what kind of format should be accepted:loki
is the currently accepted snappy RPC formatplaintext
andndjson
are newline delimited text formats. Each line in the request body will render a longline in LokiWhich issue(s) this PR fixes:
Fixes #4316
Special notes for your reviewer:
Checklist