Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always expose loki_build_info #4482

Merged
merged 1 commit into from
Oct 15, 2021
Merged

always expose loki_build_info #4482

merged 1 commit into from
Oct 15, 2021

Conversation

owen-d
Copy link
Member

@owen-d owen-d commented Oct 14, 2021

This moves registration of the loki_build_info metric from a hook in main.go to the server submodule, which enforces it's registration when used as a library as well.

@owen-d owen-d requested a review from a team as a code owner October 14, 2021 22:26
slim-bean
slim-bean approved these changes Oct 14, 2021
View reviewed changes
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLLLLLLLLLGTM

@owen-d owen-d merged commit 7832783 into grafana:main Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slim-bean slim-bean slim-bean approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owen-d @slim-bean