Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor client configs in Promtail. #4567

Merged
merged 1 commit into from
Oct 27, 2021

Conversation

cyriltovena
Copy link
Contributor

This refactor a bit how we mutate the original config for backward compatibility.
Also add tests on untested code path.

Signed-off-by: Cyril Tovena cyril.tovena@gmail.com

This refactor a big how we mutate the original config for backward compatibility.
Also add tests on untested code path.

Signed-off-by: Cyril Tovena <cyril.tovena@gmail.com>
@cyriltovena cyriltovena requested a review from a team as a code owner October 27, 2021 14:23
@cyriltovena
Copy link
Contributor Author

Nothing urgent but I wanted to split my bigger kafka PR.

Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 93a0b71 into grafana:main Oct 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants