[Promtail] resolve issue with promtail not scraping target if only path changed in a simpler way that dont need mutex to sync threads #4599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in a simpler way that dont need mutex to sync threads Signed-off-by: Roger Steneteg <rsteneteg@ea.com>
kavirajk
reviewed
Nov 1, 2021
| level.Debug(s.log).Log("msg", "ignoring target, already exists", "labels", labels.String()) | ||
| s.metrics.failedTargets.WithLabelValues("exists").Inc() | ||
| } | ||
| if _, ok := s.targets[key]; ok { |
There was a problem hiding this comment.
Not an promtail expert. Leave it @slim-bean for the final approval.
I still do think we need some tests to lock this behaviour!
|
@slim-bean should we merge ? |
rfratto
reviewed
Nov 3, 2021
|
@rsteneteg may I ask if this PR is going to fix #3698 also? I fear it does not. |
|
@Mario-Hofstaetter it looks like this change would also fix #3698, since the path variable is used within the key it would no longer be seen as a duplicate and ignored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve issue with promtail not scraping target if only path changed in a simpler way that dont need mutex to sync threads
Signed-off-by: Roger Steneteg rsteneteg@ea.com
What this PR does / why we need it:
Resolves an issue in a better way, that don't require sharing variables between theads that would require a mutex to synchronize goroutines.
Which issue(s) this PR fixes:
Fixes #4581 #4460
Special notes for your reviewer:
Checklist