Add zone aware replication support #4626
Closed
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
check-generated-files step looks broken in CI. |
taisho6339
force-pushed
the
feature/issue-4600
branch
from
2ac682f
to
0368f74
Compare
GrafanaWriter
approved these changes
Nov 3, 2021
Co-authored-by: Fiona Artiaga <89225282+GrafanaWriter@users.noreply.github.com>
|
apparently, these changes have already merged by another PR so I'll close it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To support zone aware replication, I've added some codes and documents.
Cortex already supports this feature and Loki uses same codes for resolving ingester instances so I think we can already use this feature in also Loki.
In addition, lifecycler and ring config is exactly same as Cortex's
Which issue(s) this PR fixes:
Fixes #4600
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.