Fix duplicate registry.MustRegister call in Promtail Kafka #4866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* registry.MustRegister is called every newPipeline so ensure it only at once
taisho6339
force-pushed
the
fix/issues/4865
branch
from
5aa1240
to
72b9350
Compare
dannykopping
approved these changes
Dec 3, 2021
There was a problem hiding this comment.
LGTM, thanks @taisho6339 🙏
Let's wait for @cyriltovena to confirm before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
registry.MustRegister is called every newPipeline and newPipeline is called in every newTarget in target_syncer.go.
Therefore MustRegister is called in duplicate and it causes the metrics collection error.
I've moved the newPipeline to newTargetsyncer to fix it.
Which issue(s) this PR fixes:
Fixes #4865
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.