Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output spelling of cancelled #5326

Closed

Conversation

KMiller-Grafana
Copy link
Contributor

PR #5297 introduced msg output with an alternate spelling of "cancelled" that only had 1 'l' and not two. This meant that some messages used "canceled" and others used "cancelled." This PR changes all spellings to be "cancelled."

I specifically did not change function/method name or variable spellings. Just the strings.

@KMiller-Grafana KMiller-Grafana requested a review from a team as a code owner February 4, 2022 23:18
@vlad-diachenko
Copy link
Contributor

vlad-diachenko commented Feb 7, 2022

Hi @KMiller-Grafana . this error message canceled (with 1 l) comes from built-in golang libraries and from GRPC module. I do not think that we can change it...
Also, we can fix the text exact in this test file, however, errors in runtime will be with 1 l anyway.
if it's critical, we can try to analyse how to fix it. What do you think?

@KMiller-Grafana
Copy link
Contributor Author

Thanks, @vlad-diachenko. I didn't realize that these strings were matched against ones with a different spelling. I'll close the PR, as there's nothing to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants