Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a DeletionMode config variable #5481

Merged
merged 48 commits into from
Apr 6, 2022
Merged

Add a DeletionMode config variable #5481

merged 48 commits into from
Apr 6, 2022

Commits on Apr 6, 2022

  1. Add deletionEnabled setting and remove delete request manager 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    929cbbe View commit details
    Browse the repository at this point in the history

  2. Rebase 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    42bfebf View commit details
    Browse the repository at this point in the history

  3. Remove deletion handling from delete requests manager 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    a6ed435 View commit details
    Browse the repository at this point in the history

  4. change store so it stores a logql statement 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    3ce76d6 View commit details
    Browse the repository at this point in the history

  5. Add validation code for logql statement 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    bb2b3eb View commit details
    Browse the repository at this point in the history

  6. Run deleteRequestsManager when deletion is enabled 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    9397b50 View commit details
    Browse the repository at this point in the history

  7. Remove unused variables 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    6f676aa View commit details
    Browse the repository at this point in the history

  8. Revert "Remove deletion handling from delete requests manager" 

    This reverts commit ce4f774497aa590caff86b0745ec81588592a9e1.
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    e1afcc3 View commit details
    Browse the repository at this point in the history

  9. Re-add IsDeleted method 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    f6eb37e View commit details
    Browse the repository at this point in the history

  10. Re-add tests for IsDeleted 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    0fbdbe1 View commit details
    Browse the repository at this point in the history

  11. Fix delete request store test 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    5495668 View commit details
    Browse the repository at this point in the history

  12. Fix linting issue 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    027adfd View commit details
    Browse the repository at this point in the history

  13. Revert compactor changes 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    587f6d2 View commit details
    Browse the repository at this point in the history

  14. Add deletion mode 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    b10e121 View commit details
    Browse the repository at this point in the history

  15. Add v1 mode 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    b90811a View commit details
    Browse the repository at this point in the history

  16. Rename LogQLRequest to Query 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    6a7ca3a View commit details
    Browse the repository at this point in the history

  17. Fix linting issues 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    815c617 View commit details
    Browse the repository at this point in the history

  18. Use DeleteMode in compactor module 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    a9b8f73 View commit details
    Browse the repository at this point in the history

  19. Rename logql to query 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    65504d0 View commit details
    Browse the repository at this point in the history

  20. Put cancel under delete verb 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    e75c36b View commit details
    Browse the repository at this point in the history

  21. Update documentation 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    1a5069b View commit details
    Browse the repository at this point in the history

  22. Update changelog 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    dc4ab08 View commit details
    Browse the repository at this point in the history

  23. Revert only the API surface area while keeping everything else

    @MasslessParticle @MichelHollands
    MasslessParticle authored and MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    b00482c View commit details
    Browse the repository at this point in the history

  24. Use moved code in syntax package 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    38d819f View commit details
    Browse the repository at this point in the history

  25. Remove duplicte import 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    3ae0aea View commit details
    Browse the repository at this point in the history

  26. Use renamed field in tests 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    b6b4734 View commit details
    Browse the repository at this point in the history

  27. Remove duplicates and empty lines in changelog 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    beddf81 View commit details
    Browse the repository at this point in the history

  28. Update changelog description 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    e3dbe38 View commit details
    Browse the repository at this point in the history

  29. Update pkg/storage/stores/shipper/compactor/deletion/delete_request.go 

    Co-authored-by: Christian Simon <simon@swine.de>
    @MichelHollands @simonswine
    MichelHollands and simonswine committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    1ba285a View commit details
    Browse the repository at this point in the history

  30. Update pkg/storage/stores/shipper/compactor/deletion/delete_requests_… 

    …manager_test.go

Co-authored-by: Christian Simon <simon@swine.de>
    @MichelHollands @simonswine
    MichelHollands and simonswine committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    8152916 View commit details
    Browse the repository at this point in the history

  31. Update pkg/storage/stores/shipper/compactor/deletion/delete_requests_… 

    …store.go

Co-authored-by: Christian Simon <simon@swine.de>
    @MichelHollands @simonswine
    MichelHollands and simonswine committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    eb46a59 View commit details
    Browse the repository at this point in the history

  32. Update pkg/storage/stores/shipper/compactor/deletion/delete_requests_… 

    …store.go

Co-authored-by: Christian Simon <simon@swine.de>
    @MichelHollands @simonswine
    MichelHollands and simonswine committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    197e08b View commit details
    Browse the repository at this point in the history

  33. Update CHANGELOG.md 

    Co-authored-by: Christian Simon <simon@swine.de>
    @MichelHollands @simonswine
    MichelHollands and simonswine committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    ff27a1b View commit details
    Browse the repository at this point in the history

  34. Update pkg/storage/stores/shipper/compactor/deletion/delete_requests_… 

    …store.go

Co-authored-by: Christian Simon <simon@swine.de>
    @MichelHollands @simonswine
    MichelHollands and simonswine committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    d249f18 View commit details
    Browse the repository at this point in the history

  35. Make DeletionMode struct member non public 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    0b35252 View commit details
    Browse the repository at this point in the history

  36. Revert change to docs re cancellation 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    0b49512 View commit details
    Browse the repository at this point in the history

  37. Use same variable names 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    1db21ca View commit details
    Browse the repository at this point in the history

  38. Add parameter validation to changelog 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    92aa117 View commit details
    Browse the repository at this point in the history

  39. Rename v1 to WholeStreamDeletion 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    a574d62 View commit details
    Browse the repository at this point in the history

  40. Fix default value of deletion mode config setting 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    8098e1b View commit details
    Browse the repository at this point in the history

  41. reimplement new api

    @MasslessParticle @MichelHollands
    MasslessParticle authored and MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    86a2a53 View commit details
    Browse the repository at this point in the history

  42. Add delete request handler when delete mode is set 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    16e9ab2 View commit details
    Browse the repository at this point in the history

  43. Remove unused variable 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    9bec8a1 View commit details
    Browse the repository at this point in the history

  44. Add comment to change the code when other deletion modes are available 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    a10466b View commit details
    Browse the repository at this point in the history

  45. create expirationChecker if deletionMode is set 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    f9addc8 View commit details
    Browse the repository at this point in the history

  46. Address review comments 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    85a32ea View commit details
    Browse the repository at this point in the history

  47. Update pkg/storage/stores/shipper/compactor/compactor.go 

    Co-authored-by: Sandeep Sukhani <sandeep.d.sukhani@gmail.com>
    @MichelHollands @sandeepsukhani
    MichelHollands and sandeepsukhani authored Apr 6, 2022
    Configuration menu
    Copy the full SHA
    a12b157 View commit details
    Browse the repository at this point in the history

  48. Rename AddQuery to SetQuery 

    Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
    @MichelHollands
    MichelHollands committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    9d6dc0d View commit details
    Browse the repository at this point in the history