[promtail] Refactor promtail client metrics so that we can't have duplicate metrics collected for the lag metric. #5521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
collected for the lag metric. Signed-off-by: Callum Styan <callumstyan@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
Signed-off-by: Callum Styan <callumstyan@gmail.com>
cstyan
changed the title
cyriltovena
reviewed
Mar 8, 2022
| lblSet[HostLabel] = c.cfg.URL.Host | ||
| // also set client name since if we have multiple promtail clients configured we will run into a | ||
| // duplicate metric collected with same labels error when trying to hit the /metrics endpoint | ||
| lblSet[ClientLabel] = c.name |
There was a problem hiding this comment.
id or config id would have work better IMO.
There was a problem hiding this comment.
for the configuration field name?
configs. Signed-off-by: Callum Styan <callumstyan@gmail.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still some things I need to fix, but some quick reivews/sanity checks would be good.
So, this should solve #5494
The cause of the issue is relatively simple, there was nothing in our code ensuring that for multiple promtail clients in the same binary that this metric would have a unique labelset per client. External labels are not applied to the metrics on
/metrics. I've done a few things in this PR:main.go, and the metrics struct is passed in to client constructors from thereSigned-off-by: Callum Styan callumstyan@gmail.com