-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
operator: Document how to connect to distributor component #5551
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a few comments:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally did a first read-through, sorry for the long wait.
929a804
to
4d6e7e4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, missed the YAML style the last time. Personally I like the non-quoted style better for YAML, because there's less distracting characters, but at least we should apply one style consistently.
4d6e7e4
to
89036e1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
During a discussion with @periklis about connecting Grafana to LokiStack we came to the conclusion that this document needs to be better marked as "only for testing". See my (hopefully final) suggestion.
836f1b9
to
4d966b8
Compare
(cherry picked from commit 5e5067e)
) (grafana#5811) (cherry picked from commit 5e5067e) Co-authored-by: Sashank Agarwal <sasagarw@redhat.com>
What this PR does / why we need it:
index.md
file.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CHANGELOG.md
about the changes.