Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fluent-bit output name #5711

Merged
merged 3 commits into from
Mar 29, 2022
Merged

Update fluent-bit output name #5711

merged 3 commits into from
Mar 29, 2022

Conversation

MichelHollands
Copy link
Contributor

What this PR does / why we need it:

The configuration of the Fluent Bit plugin uses grafana-loki as output name. In the documentation for ECS loki is used wrongly. This PR updates the ECS example to use grafana-loki as well.

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

Signed-off-by: Michel Hollands michel.hollands@grafana.com

Signed-off-by: Michel Hollands <michel.hollands@grafana.com>
Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@KMiller-Grafana KMiller-Grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dannykopping dannykopping merged commit 9d62f05 into main Mar 29, 2022
@dannykopping dannykopping deleted the fix_fluentbit_docs branch March 29, 2022 16:59
@MasslessParticle MasslessParticle added the backport release-2.5.x Tag a PR with this label to create a PR which cherry pics it into the release-2.5.x branch label Apr 7, 2022
grafanabot pushed a commit that referenced this pull request Apr 7, 2022
* Update fluent-bit output name

Signed-off-by: Michel Hollands <michel.hollands@grafana.com>

* Empty commit

* Another empty commit

(cherry picked from commit 9d62f05)
MasslessParticle pushed a commit that referenced this pull request Apr 7, 2022
* Update fluent-bit output name

Signed-off-by: Michel Hollands <michel.hollands@grafana.com>

* Empty commit

* Another empty commit

(cherry picked from commit 9d62f05)

Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
splitice pushed a commit to X4BNet/loki that referenced this pull request May 21, 2022
* Update fluent-bit output name

Signed-off-by: Michel Hollands <michel.hollands@grafana.com>

* Empty commit

* Another empty commit

(cherry picked from commit 9d62f05)

Co-authored-by: Michel Hollands <42814411+MichelHollands@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-2.5.x Tag a PR with this label to create a PR which cherry pics it into the release-2.5.x branch size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants