Promtil: Fix a panic when using the loki push api target. #5761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ed Welch <edward.welch@grafana.com>
slim-bean
added
the
backport release-2.5.x
owen-d
approved these changes
Apr 4, 2022
slim-bean
added a commit
that referenced
this pull request
Apr 6, 2022
splitice
pushed a commit
to X4BNet/loki
that referenced
this pull request
May 21, 2022
…rafana#5761) (grafana#5762) Signed-off-by: Ed Welch <edward.welch@grafana.com> (cherry picked from commit a9ac01b) Co-authored-by: Ed Welch <edward.welch@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
We were passing in the active metrics registry to the util tool that sets up the logger to be used by the push server, this resulted in a duplicate metrics registration.
The metric being registered is not important so this PR just passes in an empty registry to use to init the logger.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CHANGELOG.mdabout the changes.