Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Loki writes resources dashboard #5765

Merged
merged 1 commit into from
May 2, 2022
Merged

Update Loki writes resources dashboard #5765

merged 1 commit into from
May 2, 2022

Conversation

ssncferreira
Copy link
Contributor

@ssncferreira ssncferreira commented Apr 4, 2022 •
edited
Loading

What this PR does / why we need it:

Update the Loki reads/writes resources pages to not include empty rows.

Before:
old_dashboard

After:
new_dashboard

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated
  • Add an entry in the CHANGELOG.md about the changes.

@ssncferreira ssncferreira self-assigned this Apr 4, 2022
@ssncferreira ssncferreira force-pushed the writes_resources_dashboard branch 2 times, most recently from d868072 to ac57871 Compare April 29, 2022 14:46
@ssncferreira ssncferreira force-pushed the writes_resources_dashboard branch 2 times, most recently from 51278d1 to eb678dc Compare April 29, 2022 16:02
@ssncferreira ssncferreira force-pushed the writes_resources_dashboard branch from eb678dc to 58577bf Compare April 29, 2022 16:06
@ssncferreira ssncferreira force-pushed the writes_resources_dashboard branch 4 times, most recently from 4a26b29 to 1dbaa8c Compare April 29, 2022 16:48
@pull-request-size pull-request-size bot added size/M and removed size/S labels Apr 29, 2022
@ssncferreira ssncferreira force-pushed the writes_resources_dashboard branch from 1dbaa8c to 5897046 Compare April 29, 2022 16:54
@ssncferreira ssncferreira marked this pull request as ready for review April 29, 2022 17:12
@ssncferreira ssncferreira requested a review from a team as a code owner April 29, 2022 17:12
cyriltovena
cyriltovena approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 38b1d3b into main May 2, 2022
@cyriltovena cyriltovena deleted the writes_resources_dashboard branch May 2, 2022 08:31
This was referenced Jun 28, 2022
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees

@ssncferreira ssncferreira

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ssncferreira @cyriltovena