production config: add dot to some DNS address to reduce lookups #5789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kubernetes sets up a DNS search path like `namespace.svc.cluster.local, svc.cluster.local, cluster.local, google.internal`; any unqualified name is first tried as a prefix to each of these. These requests, which will never succeed, add latency and increase load on the DNS service. Adding a `.` at the end makes the name fully-qualified, so Go's DNS client will skip the search path and use the name as-is. Note only changes a subset of addresses in the config; others didn't seem to be causing a problem.
Merged
This was referenced Jun 28, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Kubernetes sets up a DNS search path like
namespace.svc.cluster.local, svc.cluster.local, cluster.local, google.internal; any unqualified name is first tried as a prefix to each of these. These requests, which will never succeed, add latency and increase load on the DNS service.Adding a
.at the end makes the name fully-qualified, so Go's DNS client will skip the search path and use the name as-is.Special notes for your reviewer:
Note this only changes a subset of addresses in the config; others didn't seem to be causing a problem and I don't have a good way to test them.
Checklist
CHANGELOG.mdabout the changes.