Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: revise getting started guide #5939

Merged
merged 12 commits into from
Apr 28, 2022

Conversation

KMiller-Grafana
Copy link
Contributor

@KMiller-Grafana KMiller-Grafana commented Apr 15, 2022

Compose a single getting started guide (instead of a section with unrelated content). Base it on the SSD Docker installation instructions.

Move unrelated content elsewhere in the doc set. Introduce appropriate aliases (metadata) for the moved content.

Use flog to do log-generation.
Make sure it is obvious that this test environment is not for a production environment.
Move the configuration that goes with this guide into a new Loki /examples directory. (Leave other example material in the /production directory to be updated and/or moved in a different PR.)

To test using the new getting started guide, copy the 3 configuration files from this PR's /examples directory. The directions in the prose can't work until after this PR is merged in, as this PR creates the /examples directory.

Copy link
Contributor

@gguillotte-grafana gguillotte-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've hit a wall at the final part, running the {job="flog"} query in Grafana. Everything appears to be working as far as I can tell, but the query returns nothing.

docs/sources/getting-started/_index.md Outdated Show resolved Hide resolved
docs/sources/getting-started/_index.md Outdated Show resolved Hide resolved
docs/sources/getting-started/_index.md Outdated Show resolved Hide resolved
docs/sources/getting-started/_index.md Outdated Show resolved Hide resolved
docs/sources/getting-started/_index.md Show resolved Hide resolved
docs/sources/getting-started/_index.md Outdated Show resolved Hide resolved
@KMiller-Grafana KMiller-Grafana marked this pull request as ready for review April 27, 2022 18:09
@KMiller-Grafana KMiller-Grafana requested a review from a team as a code owner April 27, 2022 18:09
Copy link
Contributor

@gguillotte-grafana gguillotte-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The revised steps simplify the setup process and work! Thanks, @KMiller-Grafana!

docker-compose down
```

## Modifying the flog app output
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm I think this subsection seems out-of-place/looks unnecessary. WDYT?

Copy link
Contributor Author

@KMiller-Grafana KMiller-Grafana Apr 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see what others say in their reviews. I wanted this effort to be a guide, not a tutorial. Part of making a guide is providing paths for extending what is given to what is useful for the readers.

I envision adding another section (in the future, when time allows) which shows how to run Promtail and the app outside of Docker containers. This would promote understanding of how to set up Promtail configuration.

So, in the future, I think there will be other sections that we might classify as extending the test environment to further evaluate Loki. I think that we might even use this setup (maybe replace flog with another app?) to be used as a LogQL query-writing practice area.

@DylanGuedes
Copy link
Contributor

added a few nits but overall LGTM!

Copy link
Contributor

@ssncferreira ssncferreira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏆
Thank you for this! It is written in a very clear and easy to follow along manner 🙏
Just some small suggestions

docs/sources/getting-started/_index.md Outdated Show resolved Hide resolved
docs/sources/getting-started/_index.md Show resolved Hide resolved
docs/sources/getting-started/_index.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@slim-bean slim-bean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slim-bean slim-bean added the backport release-2.5.x Tag a PR with this label to create a PR which cherry pics it into the release-2.5.x branch label Apr 28, 2022
@slim-bean slim-bean merged commit c4ebfd3 into grafana:main Apr 28, 2022
grafanabot pushed a commit that referenced this pull request Apr 28, 2022
* Revise the getting started section

* Docs: revise getting started guide

* Intermediate commit of getting started material.

* Intermediate revision of the getting started guide.

    Add instructions to download, configure, and deploy the test environment.

* Add sample queries and instructions for breaking down the test env

* Revise prose using reviewer comments.

* update to use promtail and flog in the docker compose file

Signed-off-by: Edward Welch <edward.welch@grafana.com>

* Revise guide to put all parts into Docker containers.

* Add README files for examples directory. Revise getting started instructions.

* Address DylanGuedes review comments

* Getting started guide: incorporate suggestions from ssncferreira

Co-authored-by: Edward Welch <edward.welch@grafana.com>
(cherry picked from commit c4ebfd3)
slim-bean pushed a commit that referenced this pull request Apr 28, 2022
* Revise the getting started section

* Docs: revise getting started guide

* Intermediate commit of getting started material.

* Intermediate revision of the getting started guide.

    Add instructions to download, configure, and deploy the test environment.

* Add sample queries and instructions for breaking down the test env

* Revise prose using reviewer comments.

* update to use promtail and flog in the docker compose file

Signed-off-by: Edward Welch <edward.welch@grafana.com>

* Revise guide to put all parts into Docker containers.

* Add README files for examples directory. Revise getting started instructions.

* Address DylanGuedes review comments

* Getting started guide: incorporate suggestions from ssncferreira

Co-authored-by: Edward Welch <edward.welch@grafana.com>
(cherry picked from commit c4ebfd3)

Co-authored-by: Karen Miller <84039272+KMiller-Grafana@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport release-2.5.x Tag a PR with this label to create a PR which cherry pics it into the release-2.5.x branch size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants