Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove empty match within concat of regex #6026

Merged
merged 2 commits into from
Apr 26, 2022
Merged

Remove empty match within concat of regex #6026

merged 2 commits into from
Apr 26, 2022

Conversation

cyriltovena
Copy link
Contributor

Regexes with concat alternate that contains empty matches are not required for filtering.

For instance (?:)bar|foo is exactly the same as bar|foo

@cyriltovena cyriltovena requested a review from a team as a code owner April 26, 2022 13:41
kavirajk
kavirajk approved these changes Apr 26, 2022
View reviewed changes
Copy link
Contributor

@kavirajk kavirajk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kavirajk kavirajk merged commit 986fe5c into grafana:main Apr 26, 2022
This was referenced Jun 28, 2022
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavirajk kavirajk kavirajk approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cyriltovena @kavirajk